Performance improvements#10
Merged
Merged
Conversation
jedibob5
commented
Jun 28, 2025
| orderedStats := CollegeStats | ||
| resultList := []structs.CollegePlayer{} | ||
| if statType == "PASSING" { | ||
| switch statType { |
Collaborator
Author
There was a problem hiding this comment.
VSCode offered to auto-convert these to switch statements, and I figured why not.
CalebRose
approved these changes
Jun 28, 2025
Owner
|
Approved. For some reason the CI/CD pipeline check is failing but it might work once this merges into the main branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to make several performance improvements on the API. From testing, the Facedata retrieval was the longest part of the Bootstrap 1 call, and shouldn't be necessary to displaying the initial homepage. This has been moved to Bootstrap 3 to let that finish in the background. Additionally, for the football bootstrap data, EasyJSON a new, more performant JSON encoder, was employed to allow the API to marshal the JSON responses to the bootstap calls more quickly.
Based on local testing, the response time for Bootstrap 1 has been improved by about 2 seconds, and although Bootstrap 3 takes about a second longer now, it happens in the background after the page loads, so it should be less noticeable to the user. Response times in Azure seems to be significantly different compared to local, so the final impact there probably won't be known until merge, but it should be faster.
NOTE: This will require a small change on the V2 interface to work correctly. The PR for this change is here. If either change is deployed without the other, attempting to open a player card will crash the page!
Local testing results:
Main branch, without changes:
Bootstrap one response time: 5148ms
Bootstrap three response time: 4210ms
Performance branch, with changes:
Bootstrap one response time: 3117ms
Bootstrap three response time: 5351ms